Skip to content

fix: [OTLP] detect http/https protocol from parsedUrl.protocol#9028

Merged
BridgeAR merged 6 commits into
masterfrom
ida613/otlp-trace-fix
Jun 25, 2026
Merged

fix: [OTLP] detect http/https protocol from parsedUrl.protocol#9028
BridgeAR merged 6 commits into
masterfrom
ida613/otlp-trace-fix

Conversation

@ida613

@ida613 ida613 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

As title, ensures https payloads are encrypted

Motivation

Additional Notes

@ida613 ida613 requested a review from a team as a code owner June 22, 2026 19:58
@ida613 ida613 requested review from khanayan123 and removed request for a team June 22, 2026 19:58
@ida613 ida613 requested a review from a team June 22, 2026 19:58
@ida613 ida613 changed the title fix: OTLP trace export - detect http/https protocol from prasedUrl.protocol fix: OTLP trace export - detect http/https protocol from parsedUrl.protocol Jun 22, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 6.34 MB
Deduped: 7.41 MB
No deduping: 7.41 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.2.0 | 104.26 kB | 843.44 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jun 22, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b465d1f | Docs | Datadog PR Page | Give us feedback!

@ida613 ida613 changed the title fix: OTLP trace export - detect http/https protocol from parsedUrl.protocol fix: [OTLP] detect http/https protocol from parsedUrl.protocol Jun 22, 2026
Comment thread packages/dd-trace/src/opentelemetry/otlp/otlp_http_exporter_base.js Outdated
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.95%. Comparing base (2da11d0) to head (b465d1f).
⚠️ Report is 34 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9028      +/-   ##
==========================================
- Coverage   93.43%   92.95%   -0.48%     
==========================================
  Files         879      885       +6     
  Lines       50450    50764     +314     
  Branches     9930    10016      +86     
==========================================
+ Hits        47137    47187      +50     
- Misses       3313     3577     +264     
Flag Coverage Δ
aiguard-integration-active 41.73% <ø> (+0.09%) ⬆️
aiguard-integration-latest 41.73% <ø> (+0.08%) ⬆️
aiguard-integration-maintenance 41.82% <ø> (+0.10%) ⬆️
aiguard-macos 34.56% <ø> (+<0.01%) ⬆️
aiguard-ubuntu 34.71% <ø> (+<0.01%) ⬆️
aiguard-windows 34.39% <ø> (+<0.01%) ⬆️
apm-capabilities-tracing-macos 48.24% <100.00%> (+0.07%) ⬆️
apm-capabilities-tracing-ubuntu-active 48.41% <100.00%> (+0.25%) ⬆️
apm-capabilities-tracing-ubuntu-latest 48.23% <100.00%> (-0.10%) ⬇️
apm-capabilities-tracing-ubuntu-maintenance 48.45% <100.00%> (+0.24%) ⬆️
apm-capabilities-tracing-ubuntu-oldest ?
apm-capabilities-tracing-windows ?
apm-integrations-aerospike-18-gte.5.2.0 33.09% <ø> (+<0.01%) ⬆️
apm-integrations-aerospike-20-gte.5.5.0 33.11% <ø> (+<0.01%) ⬆️
apm-integrations-aerospike-22-gte.5.12.1 33.11% <ø> (+<0.01%) ⬆️
apm-integrations-aerospike-22-gte.6.0.0 33.11% <ø> (+<0.01%) ⬆️
apm-integrations-aerospike-eol- 33.01% <ø> (+<0.01%) ⬆️
apm-integrations-child-process 34.02% <ø> (-0.01%) ⬇️
apm-integrations-confluentinc-kafka-javascript-18 40.03% <ø> (-0.01%) ⬇️
apm-integrations-confluentinc-kafka-javascript-20 40.04% <ø> (-0.01%) ⬇️
apm-integrations-confluentinc-kafka-javascript-22 40.05% <ø> (-0.01%) ⬇️
apm-integrations-confluentinc-kafka-javascript-24 39.94% <ø> (-0.01%) ⬇️
apm-integrations-couchbase-18 33.27% <ø> (+0.16%) ⬆️
apm-integrations-couchbase-eol 33.15% <ø> (-0.17%) ⬇️
apm-integrations-dns 33.26% <ø> (+0.31%) ⬆️
apm-integrations-elasticsearch 34.14% <ø> (+0.03%) ⬆️
apm-integrations-http-latest 41.96% <ø> (+0.15%) ⬆️
apm-integrations-http-maintenance 42.05% <ø> (+0.15%) ⬆️
apm-integrations-http-oldest 41.98% <ø> (+0.15%) ⬆️
apm-integrations-http2 38.90% <ø> (-0.17%) ⬇️
apm-integrations-kafkajs-latest 40.08% <ø> (-0.01%) ⬇️
apm-integrations-kafkajs-oldest 40.16% <ø> (-0.11%) ⬇️
apm-integrations-net 33.64% <ø> (+<0.01%) ⬆️
apm-integrations-next-11.1.4 36.30% <ø> (-0.23%) ⬇️
apm-integrations-next-12.3.7 36.30% <ø> (-0.23%) ⬇️
apm-integrations-next-13.0.0 29.10% <ø> (+0.02%) ⬆️
apm-integrations-next-13.2.0 29.10% <ø> (+0.02%) ⬆️
apm-integrations-next-13.5.11 29.23% <ø> (+0.02%) ⬆️
apm-integrations-next-14.0.0 29.16% <ø> (+0.02%) ⬆️
apm-integrations-next-14.2.35 29.16% <ø> (-0.02%) ⬇️
apm-integrations-next-14.2.6 29.16% <ø> (+0.02%) ⬆️
apm-integrations-next-14.2.7 29.16% <ø> (+0.02%) ⬆️
apm-integrations-next-15.0.0 29.16% <ø> (+0.02%) ⬆️
apm-integrations-next-15.4.0 29.23% <ø> (+0.02%) ⬆️
apm-integrations-next-latest 29.27% <ø> (-0.02%) ⬇️
apm-integrations-oracledb 34.13% <ø> (+0.17%) ⬆️
apm-integrations-prisma-18-gte.6.16.0.and.lt.7.0.0 34.79% <ø> (-0.01%) ⬇️
apm-integrations-prisma-latest-all 34.22% <ø> (-0.02%) ⬇️
apm-integrations-restify 35.62% <ø> (+0.42%) ⬆️
apm-integrations-sharedb 32.55% <ø> (+0.10%) ⬆️
apm-integrations-tedious 33.89% <ø> (+0.52%) ⬆️
appsec-express 51.28% <ø> (+0.35%) ⬆️
appsec-fastify 48.07% <ø> (+0.35%) ⬆️
appsec-graphql 47.76% <ø> (-0.01%) ⬇️
appsec-integration-active 36.10% <ø> (+0.06%) ⬆️
appsec-integration-latest 36.10% <ø> (+0.06%) ⬆️
appsec-integration-maintenance 36.16% <ø> (+0.06%) ⬆️
appsec-integration-oldest 36.16% <ø> (+0.06%) ⬆️
appsec-kafka 40.33% <ø> (+0.04%) ⬆️
appsec-ldapjs 39.80% <ø> (-0.02%) ⬇️
appsec-lodash 39.72% <ø> (-0.02%) ⬇️
appsec-macos 57.23% <ø> (+0.21%) ⬆️
appsec-mongodb-core 43.89% <ø> (-0.02%) ⬇️
appsec-mongoose 44.75% <ø> (-0.02%) ⬇️
appsec-mysql 47.08% <ø> (+0.10%) ⬆️
appsec-next-latest-11.1.4 27.39% <ø> (+0.02%) ⬆️
appsec-next-latest-12.3.7 27.40% <ø> (+0.25%) ⬆️
appsec-next-latest-13.0.0 29.18% <ø> (+0.02%) ⬆️
appsec-next-latest-13.2.0 29.20% <ø> (+0.02%) ⬆️
appsec-next-latest-13.5.11 29.29% <ø> (+0.02%) ⬆️
appsec-next-latest-14.0.0 29.22% <ø> (?)
appsec-next-latest-14.2.35 29.22% <ø> (+0.02%) ⬆️
appsec-next-latest-14.2.6 29.22% <ø> (+0.02%) ⬆️
appsec-next-latest-14.2.7 29.22% <ø> (+0.02%) ⬆️
appsec-next-latest-15.0.0 29.22% <ø> (+0.02%) ⬆️
appsec-next-latest-latest 29.26% <ø> (+0.02%) ⬆️
appsec-next-oldest-11.1.4 27.44% <ø> (+0.02%) ⬆️
appsec-next-oldest-12.3.7 29.24% <ø> (+0.02%) ⬆️
appsec-next-oldest-13.0.0 29.24% <ø> (+0.02%) ⬆️
appsec-next-oldest-13.2.0 29.50% <ø> (+0.02%) ⬆️
appsec-next-oldest-13.5.11 29.59% <ø> (+0.02%) ⬆️
appsec-next-oldest-14.0.0 29.53% <ø> (+0.02%) ⬆️
appsec-next-oldest-14.2.35 29.53% <ø> (+0.02%) ⬆️
appsec-next-oldest-14.2.6 29.53% <ø> (+0.02%) ⬆️
appsec-next-oldest-14.2.7 29.53% <ø> (+0.02%) ⬆️
appsec-next-oldest-15.0.0 29.53% <ø> (+0.02%) ⬆️
appsec-next-oldest-latest 27.60% <ø> (+0.25%) ⬆️
appsec-node-serialize 39.01% <ø> (-0.05%) ⬇️
appsec-passport 42.64% <ø> (-0.03%) ⬇️
appsec-postgres 46.90% <ø> (+0.18%) ⬆️
appsec-sourcing 38.49% <ø> (+<0.01%) ⬆️
appsec-stripe 40.53% <ø> (-0.01%) ⬇️
appsec-template 39.30% <ø> (-0.02%) ⬇️
appsec-ubuntu 57.27% <ø> (+0.14%) ⬆️
appsec-windows 57.01% <ø> (+0.14%) ⬆️
debugger-ubuntu-active 43.35% <ø> (-0.02%) ⬇️
debugger-ubuntu-latest ?
debugger-ubuntu-maintenance 43.47% <ø> (-0.02%) ⬇️
debugger-ubuntu-oldest 43.77% <ø> (-0.03%) ⬇️
instrumentations-instrumentation-ai 45.53% <ø> (+0.37%) ⬆️
instrumentations-instrumentation-aws-sdk 45.11% <ø> (+0.35%) ⬆️
instrumentations-instrumentation-bluebird 27.61% <ø> (+0.02%) ⬆️
instrumentations-instrumentation-body-parser 35.64% <ø> (-0.01%) ⬇️
instrumentations-instrumentation-child_process 33.32% <ø> (+<0.01%) ⬆️
instrumentations-instrumentation-connect 48.51% <ø> (+0.46%) ⬆️
instrumentations-instrumentation-cookie-parser 29.51% <ø> (+0.01%) ⬆️
instrumentations-instrumentation-couchbase-18 46.23% <ø> (+0.40%) ⬆️
instrumentations-instrumentation-couchbase-eol 46.23% <ø> (+0.40%) ⬆️
instrumentations-instrumentation-crypto 27.58% <ø> (+0.02%) ⬆️
instrumentations-instrumentation-express 29.71% <ø> (+0.01%) ⬆️
instrumentations-instrumentation-express-mongo-sanitize 29.62% <ø> (+0.01%) ⬆️
instrumentations-instrumentation-express-multi-version 41.80% <ø> (+0.32%) ⬆️
instrumentations-instrumentation-express-session 35.47% <ø> (-0.01%) ⬇️
instrumentations-instrumentation-fastify 48.47% <ø> (+0.42%) ⬆️
instrumentations-instrumentation-fetch 45.21% <ø> (+0.44%) ⬆️
instrumentations-instrumentation-fs 27.29% <ø> (+0.02%) ⬆️
instrumentations-instrumentation-generic-pool 27.49% <ø> (+0.15%) ⬆️
instrumentations-instrumentation-hono 28.82% <ø> (+0.01%) ⬆️
instrumentations-instrumentation-http 37.91% <ø> (+<0.01%) ⬆️
instrumentations-instrumentation-http-client-options 37.52% <ø> (+<0.01%) ⬆️
instrumentations-instrumentation-kafkajs 49.19% <ø> (+0.43%) ⬆️
instrumentations-instrumentation-knex 27.60% <ø> (+0.02%) ⬆️
instrumentations-instrumentation-koa 46.11% <ø> (+0.39%) ⬆️
instrumentations-instrumentation-light-my-request 35.29% <ø> (-0.01%) ⬇️
instrumentations-instrumentation-mongoose 28.71% <ø> (+0.01%) ⬆️
instrumentations-instrumentation-multer 35.32% <ø> (-0.01%) ⬇️
instrumentations-instrumentation-mysql2 33.43% <ø> (+<0.01%) ⬆️
instrumentations-instrumentation-openai-lifecycle 46.21% <ø> (+0.39%) ⬆️
instrumentations-instrumentation-otel-sdk-trace 25.46% <ø> (+0.11%) ⬆️
instrumentations-instrumentation-passport 39.25% <ø> (+0.04%) ⬆️
instrumentations-instrumentation-passport-http 38.95% <ø> (+0.04%) ⬆️
instrumentations-instrumentation-passport-local 39.40% <ø> (+0.04%) ⬆️
instrumentations-instrumentation-pg 33.16% <ø> (+<0.01%) ⬆️
instrumentations-instrumentation-promise 27.56% <ø> (+0.02%) ⬆️
instrumentations-instrumentation-promise-js 27.56% <ø> (+0.02%) ⬆️
instrumentations-instrumentation-q 27.59% <ø> (+0.02%) ⬆️
instrumentations-instrumentation-restify 47.75% <ø> (+0.45%) ⬆️
instrumentations-instrumentation-router 43.64% <ø> (+0.27%) ⬆️
instrumentations-instrumentation-stripe 28.10% <ø> (+0.02%) ⬆️
instrumentations-instrumentation-url 27.41% <ø> (+0.02%) ⬆️
instrumentations-instrumentation-when 27.57% <ø> (+0.02%) ⬆️
instrumentations-instrumentation-zlib 27.46% <ø> (+0.02%) ⬆️
instrumentations-integration-esbuild-0.16.12-active 24.69% <ø> (+<0.01%) ⬆️
instrumentations-integration-esbuild-0.16.12-latest ?
instrumentations-integration-esbuild-0.16.12-maintenance 18.73% <ø> (+0.03%) ⬆️
instrumentations-integration-esbuild-0.16.12-oldest 18.72% <ø> (+0.03%) ⬆️
instrumentations-integration-esbuild-latest-active 24.69% <ø> (+<0.01%) ⬆️
instrumentations-integration-esbuild-latest-latest 24.69% <ø> (+<0.01%) ⬆️
instrumentations-integration-esbuild-latest-maintenance ?
instrumentations-integration-esbuild-latest-oldest 18.72% <ø> (+0.03%) ⬆️
llmobs-ai 35.10% <ø> (-0.03%) ⬇️
llmobs-anthropic 36.52% <ø> (-0.01%) ⬇️
llmobs-bedrock 36.01% <ø> (-0.03%) ⬇️
llmobs-google-genai 35.95% <ø> (-0.01%) ⬇️
llmobs-langchain ?
llmobs-openai-latest 39.42% <ø> (-0.02%) ⬇️
llmobs-openai-oldest 39.50% <ø> (-0.02%) ⬇️
llmobs-sdk-active 43.36% <ø> (+0.04%) ⬆️
llmobs-sdk-latest 43.36% <ø> (+0.04%) ⬆️
llmobs-sdk-maintenance 43.47% <ø> (+0.04%) ⬆️
llmobs-sdk-oldest 43.45% <ø> (+0.04%) ⬆️
llmobs-vertex-ai 35.63% <ø> (-0.16%) ⬇️
master-coverage 92.95% <100.00%> (?)
openfeature-macos 37.48% <ø> (+0.07%) ⬆️
openfeature-ubuntu 37.62% <ø> (+0.06%) ⬆️
openfeature-unit-active 50.00% <ø> (+0.04%) ⬆️
openfeature-unit-latest 50.00% <ø> (+0.04%) ⬆️
openfeature-unit-maintenance 50.36% <ø> (+0.03%) ⬆️
openfeature-unit-oldest 50.36% <ø> (+0.03%) ⬆️
openfeature-windows 37.31% <ø> (+0.06%) ⬆️
platform-core 46.47% <ø> (+0.48%) ⬆️
platform-esbuild 18.67% <ø> (-28.34%) ⬇️
platform-instrumentations-misc 29.57% <ø> (+0.21%) ⬆️
platform-integration-active 47.29% <88.88%> (+0.31%) ⬆️
platform-integration-latest 47.27% <88.88%> (+0.29%) ⬆️
platform-integration-maintenance 47.07% <88.88%> (-0.01%) ⬇️
platform-integration-oldest ?
platform-shimmer 47.50% <ø> (+0.44%) ⬆️
platform-unit-guardrails 44.42% <ø> (+0.38%) ⬆️
platform-webpack 18.31% <ø> (+0.09%) ⬆️
plugins-aws-durable-execution-sdk-js 32.82% <ø> (-0.02%) ⬇️
plugins-axios 35.46% <ø> (+0.08%) ⬆️
plugins-azure-cosmos 35.97% <ø> (+0.19%) ⬆️
plugins-azure-event-hubs 34.82% <ø> (+0.15%) ⬆️
plugins-azure-service-bus 35.33% <ø> (+0.14%) ⬆️
plugins-body-parser 36.42% <ø> (+0.06%) ⬆️
plugins-bullmq 39.43% <ø> (+<0.01%) ⬆️
plugins-cassandra 33.74% <ø> (+0.15%) ⬆️
plugins-cookie 40.72% <ø> (+0.25%) ⬆️
plugins-cookie-parser 40.55% <ø> (+0.24%) ⬆️
plugins-crypto 42.71% <ø> (+0.35%) ⬆️
plugins-dd-trace-api 33.17% <ø> (-0.02%) ⬇️
plugins-express-mongo-sanitize 40.60% <ø> (+0.24%) ⬆️
plugins-express-session 40.46% <ø> (+0.24%) ⬆️
plugins-fastify 37.76% <ø> (-0.02%) ⬇️
plugins-fetch 34.52% <ø> (+0.01%) ⬆️
plugins-fs 33.60% <ø> (+<0.01%) ⬆️
plugins-generic-pool 40.02% <ø> (+0.23%) ⬆️
plugins-google-cloud-pubsub 41.31% <ø> (-0.01%) ⬇️
plugins-grpc 36.47% <ø> (+0.01%) ⬆️
plugins-handlebars 40.60% <ø> (+0.24%) ⬆️
plugins-hapi 35.76% <ø> (+0.21%) ⬆️
plugins-hono 35.87% <ø> (-0.01%) ⬇️
plugins-ioredis 34.23% <ø> (-0.01%) ⬇️
plugins-jest 27.03% <ø> (+0.04%) ⬆️
plugins-knex 40.06% <ø> (+0.22%) ⬆️
plugins-langgraph 32.30% <ø> (+<0.01%) ⬆️
plugins-ldapjs 39.02% <ø> (+0.20%) ⬆️
plugins-light-my-request 40.16% <ø> (+0.23%) ⬆️
plugins-limitd-client 27.91% <ø> (?)
plugins-lodash 40.21% <ø> (+0.24%) ⬆️
plugins-mariadb 35.07% <ø> (-0.01%) ⬇️
plugins-memcached 33.62% <ø> (+<0.01%) ⬆️
plugins-microgateway-core 34.70% <ø> (-0.01%) ⬇️
plugins-modelcontextprotocol-sdk 32.26% <ø> (+<0.01%) ⬆️
plugins-moleculer 36.53% <ø> (+0.01%) ⬆️
plugins-mongodb ?
plugins-mongodb-core 35.36% <ø> (+0.01%) ⬆️
plugins-mongoose 34.51% <ø> (+0.18%) ⬆️
plugins-multer 40.52% <ø> (+0.24%) ⬆️
plugins-mysql 34.72% <ø> (+0.18%) ⬆️
plugins-mysql2 34.89% <ø> (+0.01%) ⬆️
plugins-nats 36.25% <ø> (+0.01%) ⬆️
plugins-node-serialize 40.44% <ø> (-0.06%) ⬇️
plugins-opensearch 33.68% <ø> (+0.15%) ⬆️
plugins-passport-http 40.33% <ø> (+0.24%) ⬆️
plugins-pino 29.82% <ø> (+0.01%) ⬆️
plugins-postgres 34.60% <ø> (+0.01%) ⬆️
plugins-process 42.71% <ø> (+0.35%) ⬆️
plugins-pug 40.72% <ø> (+0.25%) ⬆️
plugins-redis 34.25% <ø> (-0.01%) ⬇️
plugins-router 38.15% <ø> (-0.05%) ⬇️
plugins-sequelize 39.98% <ø> (+0.23%) ⬆️
plugins-test-and-upstream-amqp10 33.77% <ø> (+<0.01%) ⬆️
plugins-test-and-upstream-amqplib 39.09% <ø> (+0.02%) ⬆️
plugins-test-and-upstream-apollo 34.77% <ø> (-0.01%) ⬇️
plugins-test-and-upstream-avsc 33.66% <ø> (+<0.01%) ⬆️
plugins-test-and-upstream-bunyan 29.04% <ø> (+0.01%) ⬆️
plugins-test-and-upstream-connect 36.26% <ø> (-0.01%) ⬇️
plugins-test-and-upstream-graphql 35.92% <ø> (-0.01%) ⬇️
plugins-test-and-upstream-koa 35.81% <ø> (-0.01%) ⬇️
plugins-test-and-upstream-protobufjs 33.89% <ø> (+<0.01%) ⬆️
plugins-test-and-upstream-rhea 39.07% <ø> (+0.04%) ⬆️
plugins-undici 34.96% <ø> (+0.01%) ⬆️
plugins-url 42.71% <ø> (+0.35%) ⬆️
plugins-valkey 33.72% <ø> (+<0.01%) ⬆️
plugins-vm 42.71% <ø> (+0.35%) ⬆️
plugins-winston 29.71% <ø> (+0.01%) ⬆️
plugins-ws 37.01% <ø> (+<0.01%) ⬆️
profiling-macos 43.02% <ø> (+0.07%) ⬆️
profiling-ubuntu 43.40% <ø> (+0.02%) ⬆️
profiling-windows 40.86% <ø> (+0.04%) ⬆️
serverless-aws-sdk-latest-aws-sdk 33.06% <ø> (-0.01%) ⬇️
serverless-aws-sdk-latest-bedrockruntime 31.91% <ø> (-0.02%) ⬇️
serverless-aws-sdk-latest-client 36.33% <ø> (+0.12%) ⬆️
serverless-aws-sdk-latest-dynamodb 33.90% <ø> (+0.03%) ⬆️
serverless-aws-sdk-latest-eventbridge 27.10% <ø> (+0.08%) ⬆️
serverless-aws-sdk-latest-kinesis 37.09% <ø> (-0.02%) ⬇️
serverless-aws-sdk-latest-lambda 34.33% <ø> (-0.01%) ⬇️
serverless-aws-sdk-latest-s3 32.29% <ø> (-0.02%) ⬇️
serverless-aws-sdk-latest-serverless-peer-service 39.25% <ø> (-0.09%) ⬇️
serverless-aws-sdk-latest-sns 38.09% <ø> (-0.03%) ⬇️
serverless-aws-sdk-latest-sqs 37.71% <ø> (-0.02%) ⬇️
serverless-aws-sdk-latest-stepfunctions 32.93% <ø> (-0.01%) ⬇️
serverless-aws-sdk-latest-util 46.87% <ø> (+0.48%) ⬆️
serverless-aws-sdk-oldest-aws-sdk 33.18% <ø> (-0.01%) ⬇️
serverless-aws-sdk-oldest-bedrockruntime ?
serverless-aws-sdk-oldest-client 36.90% <ø> (+0.14%) ⬆️
serverless-aws-sdk-oldest-dynamodb ?
serverless-aws-sdk-oldest-eventbridge 27.18% <ø> (+0.08%) ⬆️
serverless-aws-sdk-oldest-kinesis 37.26% <ø> (-0.02%) ⬇️
serverless-aws-sdk-oldest-lambda 34.43% <ø> (-0.01%) ⬇️
serverless-aws-sdk-oldest-s3 32.42% <ø> (-0.02%) ⬇️
serverless-aws-sdk-oldest-serverless-peer-service 39.34% <ø> (+<0.01%) ⬆️
serverless-aws-sdk-oldest-sns 38.19% <ø> (-0.03%) ⬇️
serverless-aws-sdk-oldest-sqs 37.79% <ø> (-0.02%) ⬇️
serverless-aws-sdk-oldest-stepfunctions 33.03% <ø> (-0.01%) ⬇️
serverless-aws-sdk-oldest-util 47.64% <ø> (+0.51%) ⬆️
serverless-azure-durable-functions 36.78% <ø> (-0.03%) ⬇️
serverless-azure-functions-eventhubs 38.37% <ø> (+0.12%) ⬆️
serverless-azure-functions-servicebus 38.42% <ø> (+0.12%) ⬆️
serverless-lambda 34.32% <ø> (+0.11%) ⬆️
test-optimization-cucumber-latest-7.0.0 49.79% <ø> (+0.20%) ⬆️
test-optimization-cucumber-latest-latest 52.49% <ø> (+0.19%) ⬆️
test-optimization-cucumber-oldest-7.0.0 49.87% <ø> (+0.20%) ⬆️
test-optimization-cypress-latest-12.0.0-commonJS 48.20% <ø> (-0.75%) ⬇️
test-optimization-cypress-latest-12.0.0-esm 47.40% <ø> (-1.58%) ⬇️
test-optimization-cypress-latest-14.5.4-commonJS 47.97% <ø> (-0.85%) ⬇️
test-optimization-cypress-latest-14.5.4-esm 48.84% <ø> (+<0.01%) ⬆️
test-optimization-cypress-latest-latest-commonJS 49.29% <ø> (+<0.01%) ⬆️
test-optimization-cypress-latest-latest-esm 49.46% <ø> (+1.45%) ⬆️
test-optimization-cypress-oldest-12.0.0-commonJS 49.12% <ø> (+0.08%) ⬆️
test-optimization-cypress-oldest-12.0.0-esm 49.08% <ø> (+<0.01%) ⬆️
test-optimization-cypress-oldest-14.5.4-commonJS 49.00% <ø> (+0.11%) ⬆️
test-optimization-cypress-oldest-14.5.4-esm 48.93% <ø> (+1.90%) ⬆️
test-optimization-jest-latest-latest 55.19% <ø> (+0.14%) ⬆️
test-optimization-jest-latest-oldest 54.13% <ø> (+0.11%) ⬆️
test-optimization-jest-oldest-latest 55.24% <ø> (+0.14%) ⬆️
test-optimization-jest-oldest-oldest 54.14% <ø> (+0.15%) ⬆️
test-optimization-mocha-latest-latest 53.45% <ø> (+0.15%) ⬆️
test-optimization-mocha-latest-oldest ?
test-optimization-mocha-oldest-latest 53.58% <ø> (+0.15%) ⬆️
test-optimization-mocha-oldest-oldest 51.02% <ø> (+0.14%) ⬆️
test-optimization-playwright-latest-latest-playwright-active-test-span 44.10% <ø> (+0.35%) ⬆️
test-optimization-playwright-latest-latest-playwright-atr 42.91% <ø> (+0.19%) ⬆️
test-optimization-playwright-latest-latest-playwright-efd ?
test-optimization-playwright-latest-latest-playwright-final-status 43.37% <ø> (+0.17%) ⬆️
test-optimization-playwright-latest-latest-playwright-impacted-tests 42.86% <ø> (+0.08%) ⬆️
test-optimization-playwright-latest-latest-playwright-reporting ?
test-optimization-playwright-latest-latest-playwright-test-management 44.40% <ø> (+0.18%) ⬆️
test-optimization-playwright-latest-oldest-playwright-active-test-span 44.06% <ø> (+0.35%) ⬆️
test-optimization-playwright-latest-oldest-playwright-atr 42.97% <ø> (+0.19%) ⬆️
test-optimization-playwright-latest-oldest-playwright-efd 43.26% <ø> (+0.18%) ⬆️
test-optimization-playwright-latest-oldest-playwright-final-status 43.30% <ø> (+0.19%) ⬆️
test-optimization-playwright-latest-oldest-playwright-impacted-tests 42.79% <ø> (+0.09%) ⬆️
test-optimization-playwright-latest-oldest-playwright-reporting 42.74% <ø> (?)
test-optimization-playwright-latest-oldest-playwright-test-management 44.58% <ø> (+0.41%) ⬆️
test-optimization-playwright-oldest-latest-playwright-active-test-span 44.33% <ø> (+0.18%) ⬆️
test-optimization-playwright-oldest-latest-playwright-atr 42.98% <ø> (+0.17%) ⬆️
test-optimization-playwright-oldest-latest-playwright-efd 43.38% <ø> (+0.17%) ⬆️
test-optimization-playwright-oldest-latest-playwright-final-status 43.47% <ø> (+0.20%) ⬆️
test-optimization-playwright-oldest-latest-playwright-impacted-tests ?
test-optimization-playwright-oldest-latest-playwright-reporting ?
test-optimization-playwright-oldest-latest-playwright-test-management 44.45% <ø> (+0.15%) ⬆️
test-optimization-playwright-oldest-oldest-playwright-active-test-span 44.15% <ø> (?)
test-optimization-playwright-oldest-oldest-playwright-atr 43.05% <ø> (+0.19%) ⬆️
test-optimization-playwright-oldest-oldest-playwright-efd 43.32% <ø> (+0.18%) ⬆️
test-optimization-playwright-oldest-oldest-playwright-final-status 43.39% <ø> (+0.17%) ⬆️
test-optimization-playwright-oldest-oldest-playwright-impacted-tests 42.87% <ø> (+0.09%) ⬆️
test-optimization-playwright-oldest-oldest-playwright-reporting 42.80% <ø> (+0.18%) ⬆️
test-optimization-playwright-oldest-oldest-playwright-test-management 44.43% <ø> (+0.18%) ⬆️
test-optimization-selenium-latest 45.39% <ø> (+0.31%) ⬆️
test-optimization-selenium-oldest 44.98% <ø> (+0.32%) ⬆️
test-optimization-testopt-active 48.12% <ø> (+0.09%) ⬆️
test-optimization-testopt-latest 48.11% <ø> (+0.08%) ⬆️
test-optimization-testopt-maintenance 47.99% <ø> (-0.01%) ⬇️
test-optimization-testopt-oldest 49.29% <ø> (+0.17%) ⬆️
test-optimization-vitest-latest 50.79% <ø> (+0.31%) ⬆️
test-optimization-vitest-oldest 48.05% <ø> (+0.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter

pr-commenter Bot commented Jun 22, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-06-25 18:26:00

Comparing candidate commit b465d1f in PR branch ida613/otlp-trace-fix with baseline commit 2da11d0 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1950 metrics, 15 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:appsec-appsec-enabled-24

  • unstable execution_time [-150761.147µs; +148889.747µs] or [-5.756%; +5.685%]

scenario:appsec-appsec-enabled-26

  • unstable execution_time [-180.394ms; +177.624ms] or [-7.252%; +7.141%]

scenario:appsec-control-20

  • unstable execution_time [-122.790ms; +141.212ms] or [-7.167%; +8.243%]

scenario:appsec-control-24

  • unstable execution_time [-94.484ms; +92.018ms] or [-7.869%; +7.663%]

scenario:appsec-control-26

  • unstable execution_time [-95270.079µs; +96297.012µs] or [-8.079%; +8.166%]

scenario:dogstatsd-with-tags-20

  • unstable cpu_user_time [-396.457ms; +310.334ms] or [-8.144%; +6.375%]
  • unstable execution_time [-391.636ms; +310.270ms] or [-7.927%; +6.280%]

scenario:plugin-graphql-long-with-depth-and-collapse-off-24

  • unstable cpu_user_time [-253.871ms; +260.291ms] or [-5.508%; +5.647%]
  • unstable execution_time [-274.375ms; +277.706ms] or [-5.584%; +5.652%]
  • unstable max_rss_usage [-29.254MB; +37.543MB] or [-5.191%; +6.662%]

scenario:plugin-graphql-long-with-depth-off-20

  • unstable max_rss_usage [-7332.783KB; +8053.354KB] or [-5.375%; +5.904%]

scenario:plugin-graphql-long-with-depth-off-24

  • unstable max_rss_usage [-12.176MB; +20.961MB] or [-5.669%; +9.760%]

scenario:plugin-graphql-long-with-depth-off-26

  • unstable max_rss_usage [-20.246MB; +2.855MB] or [-12.086%; +1.704%]

scenario:spans-finish-later-26

  • unstable max_rss_usage [-14.057MB; +18.500MB] or [-7.866%; +10.351%]

scenario:test-optimization-large-suite-20

  • unstable max_rss_usage [-4333.750KB; +6252.750KB] or [-5.440%; +7.849%]

Comment thread packages/dd-trace/src/opentelemetry/otlp/otlp_http_exporter_base.js Outdated
Comment thread packages/dd-trace/src/opentelemetry/otlp/otlp_http_exporter_base.js Outdated

@BridgeAR BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly LGTM!

Comment thread packages/dd-trace/src/opentelemetry/otlp/otlp_http_exporter_base.js
…se.js

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
BridgeAR previously approved these changes Jun 25, 2026

@BridgeAR BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM while it would be nice to have a test case for the telemetry tags being updated

@ida613

ida613 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

LGTM while it would be nice to have a test case for the telemetry tags being updated

thanks Ruben! just added the test cases

it('sets protocol:http tag for http:// endpoint', () => {
const exporter = new OtlpHttpTraceExporter('http://collector.example/v1/traces', {}, 1000, {})

assert.ok(exporter.telemetryTags.includes('protocol:http'))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: calling setUrl here with https afterwards would be great. Everything would be tested in that case :)

Because that was the last functionality that was missing with my earlier comment

@BridgeAR BridgeAR merged commit afbb68c into master Jun 25, 2026
805 checks passed
@BridgeAR BridgeAR deleted the ida613/otlp-trace-fix branch June 25, 2026 19:13
This was referenced Jun 26, 2026
pabloerhard pushed a commit that referenced this pull request Jun 26, 2026
* detect http/https protocol from prasedUrl.protocol

* privatize the attribute this.transport

* fix ci failures

* fall back on https

* Update packages/dd-trace/src/opentelemetry/otlp/otlp_http_exporter_base.js

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

* added telemetry test cases

---------

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants